linux-kernel - Re: [PATCH] fix allmodconfig breakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0810271539500.13549@localhost.localdomain>
Date:	Mon, 27 Oct 2008 15:40:32 +0100 (CET)
From:	Roman Zippel <zippel@...ux-m68k.org>
To:	Al Viro <viro@...IV.linux.org.uk>
cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Sam Ravnborg <sam@...nborg.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix allmodconfig breakage

Hi,

On Sun, 26 Oct 2008, Al Viro wrote:

> 	If you use KCONFIG_ALLCONFIG (even with empty file) you get
> broken allmodconfig/allyesconfig; CONFIG_MODULES gets turned off,
> with obvious massive fallout.
> 
> 	Breakage had been introduced when conf_set_all_new_symbols()
> got used for allmodconfig et.al.
> 
> 	What happens is that sym_calc_value(modules_sym) done in
> conf_read_simple() sets SYMBOL_VALID on both modules_sym and MODULES.
> When we get to conf_set_all_new_symbols(), we set sym->def[S_DEF_USER]
> on everything, but it has no effect on sym->curr for the symbols that
> already have SYMBOL_VALID - these are stuck.
> 
> 	Solution: use sym_clear_all_valid() in there.  Note that it
> makes reevaluation of modules_sym redundant - sym_clear_all_valid()
> will do that itself.
> 
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>

Thanks for looking into this.

Signed-off-by: Roman Zippel <zippel@...ux-m68k.org>

bye, Roman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/