linux-kernel - Re: [PATCH 2/2] x86: replace BIO_VMERGE_BOUNDARY with BIOVEC_PHYS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081027125139I.fujita.tomonori@lab.ntt.co.jp>
Date:	Mon, 27 Oct 2008 12:52:29 +0900
From:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
To:	jeremy@...p.org
Cc:	fujita.tomonori@....ntt.co.jp, linux-kernel@...r.kernel.org,
	mingo@...e.hu, jens.axboe@...cle.com
Subject: Re: [PATCH 2/2] x86: replace BIO_VMERGE_BOUNDARY with
 BIOVEC_PHYS_MERGEABLE

On Fri, 24 Oct 2008 13:59:06 -0700
Jeremy Fitzhardinge <jeremy@...p.org> wrote:

> The bio common code no longer uses BIO_VMERGE_BOUNDARY, so replace it
> with BIOVEC_PHYS_MERGEABLE.  Also make iommu_bio_merge a boolean
> rather than a size, as befits its use.
> 
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>
> Cc: Jens Axboe <jens.axboe@...cle.com>

This doesn't look correct.

The block layer always done the physical merge if possible. We don't
provide any kernel parameter to disable it.

The iommu_bio_merge parameter had been used to enable the virtual
merge. As I wrote, the virtual merge feature was completely
removed. Effectively, the iommu_bio_merge parameter is meaningless
now.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/