linux-kernel - Re: Suspend to RAM regression in 2.6.28-rc2 (bisected)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1225133082.3796.35.camel@johannes.berg>
Date:	Mon, 27 Oct 2008 19:44:42 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Soeren Sonnenburg <kernel@....de>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	"Carlos R. Mafra" <crmafra2@...il.com>,
	linux-kernel@...r.kernel.org, tomas.winkler@...el.com,
	"John W. Linville" <linville@...driver.com>,
	linux-wireless@...r.kernel.org
Subject: Re: Suspend to RAM regression in 2.6.28-rc2 (bisected)

On Mon, 2008-10-27 at 19:31 +0100, Johannes Berg wrote:
> On Mon, 2008-10-27 at 19:07 +0100, Soeren Sonnenburg wrote:
> 
> > > Johannes, can you pls have a look?
> 
> I did, and I have no idea. Makes no sense at all.

The only thing I can remotely think of is that iwlwifi doesn't like
being called back from within the call that it did to mac80211, which
obviously happens here. But I have no idea, the code as it stands is
correct, just the interaction with iwlwifi's resume seems to be broken.

Try this patch instead:

--- everything.orig/drivers/net/wireless/iwlwifi/iwl-agn.c	2008-10-27 19:44:12.000000000 +0100
+++ everything/drivers/net/wireless/iwlwifi/iwl-agn.c	2008-10-27 19:44:15.000000000 +0100
@@ -2084,7 +2084,6 @@ static void iwl_alive_start(struct iwl_p
 		iwl4965_error_recovery(priv);
 
 	iwl_power_update_mode(priv, 1);
-	ieee80211_notify_mac(priv->hw, IEEE80211_NOTIFY_RE_ASSOC);
 
 	if (test_and_clear_bit(STATUS_MODE_PENDING, &priv->status))
 		iwl4965_set_mode(priv, priv->iw_mode);


johannes

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)