linux-kernel - Re: Suspend to RAM regression in 2.6.28-rc2 (bisected)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1225134571.3796.41.camel@johannes.berg>
Date:	Mon, 27 Oct 2008 20:09:31 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Jens Axboe <jens.axboe@...cle.com>
Cc:	"Carlos R. Mafra" <crmafra2@...il.com>,
	Soeren Sonnenburg <kernel@....de>,
	"Rafael J. Wysocki" <rjw@...k.pl>, linux-kernel@...r.kernel.org,
	tomas.winkler@...el.com,
	"John W. Linville" <linville@...driver.com>,
	linux-wireless@...r.kernel.org
Subject: Re: Suspend to RAM regression in 2.6.28-rc2 (bisected)

On Mon, 2008-10-27 at 20:06 +0100, Jens Axboe wrote:
> On Mon, Oct 27 2008, Carlos R. Mafra wrote:
> > On Mon 27.Oct'08 at 19:44:42 +0100, Johannes Berg wrote:
> > > On Mon, 2008-10-27 at 19:31 +0100, Johannes Berg wrote:
> > > > On Mon, 2008-10-27 at 19:07 +0100, Soeren Sonnenburg wrote:
> > > > 
> > > > > > Johannes, can you pls have a look?
> > > > 
> > > > I did, and I have no idea. Makes no sense at all.
> > > 
> > > The only thing I can remotely think of is that iwlwifi doesn't like
> > > being called back from within the call that it did to mac80211, which
> > > obviously happens here. But I have no idea, the code as it stands is
> > > correct, just the interaction with iwlwifi's resume seems to be broken.
> > > 
> > > Try this patch instead:
> > 
> > Yep, with this patch it also works!
> 
> Confirmed here as well, my x60 is happy again.

Thanks. Another alternative I could think of is deferring the
notifications to a work struct, but I'd rather see that in the driver I
think, not sure though, could be argued either way.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)