linux-kernel - Re: [PATCH 3/5] w35und: remove dead code from wbusb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Oct 2008 14:14:52 -0700
From:	Greg KH <greg@...ah.com>
To:	Pekka J Enberg <penberg@...helsinki.fi>
Cc:	Pavel Machek <pavel@...e.cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] w35und: remove dead code from wbusb_f.h

On Mon, Oct 27, 2008 at 10:44:19PM +0200, Pekka J Enberg wrote:
> Hi Greg,
> 
> On Wed, Oct 22, 2008 at 07:06:41PM +0300, Pekka J Enberg wrote:
> > > From: Pekka Enberg <penberg@...helsinki.fi>
> > > 
> > > Remove dead code from wbusb_f.h and move the WbWLanInitialize() definition to
> > > wblinux_f.h where it arguably belongs to. As the wbusb_f.h is now empty, we can
> > > remove it completely.
> > > 
> > > Cc: Pavel Machek <pavel@...e.cz>
> > > Signed-off-by: Pekka Enberg <penberg@...helsinki.fi>
> 
> On Mon, 27 Oct 2008, Greg KH wrote:
> > This patch gives me a bunch of build errors as I don't think you are in
> > sync with the other changes in these files.
> > 
> > Care to respin it against 2.6.28-rc2?
> 
> That's strange. I rebased against 2.6.28-rc2 but didn't get any conficts 
> and everything seems to build just fine. What kind of errors are you 
> seeing?
> 
> I've included the rediffed patch here in case it helps. Not sure why it 
> would...

I still get the following errors with this patch applied:

  CC [M]  drivers/staging/winbond/./linux/wb35reg.o
drivers/staging/winbond/./linux/wb35reg.c: In function ‘Wb35Reg_BurstWrite’:
drivers/staging/winbond/./linux/wb35reg.c:29: error: implicit declaration of function ‘wb_usb_alloc_urb’
drivers/staging/winbond/./linux/wb35reg.c:29: warning: assignment makes pointer from integer without a cast
drivers/staging/winbond/./linux/wb35reg.c: In function ‘Wb35Reg_Write’:
drivers/staging/winbond/./linux/wb35reg.c:178: warning: assignment makes pointer from integer without a cast
drivers/staging/winbond/./linux/wb35reg.c: In function ‘Wb35Reg_WriteWithCallbackValue’:
drivers/staging/winbond/./linux/wb35reg.c:238: warning: assignment makes pointer from integer without a cast
drivers/staging/winbond/./linux/wb35reg.c: In function ‘Wb35Reg_Read’:
drivers/staging/winbond/./linux/wb35reg.c:345: warning: assignment makes pointer from integer without a cast
drivers/staging/winbond/./linux/wb35reg.c: In function ‘Wb35Reg_EP0VM’:
drivers/staging/winbond/./linux/wb35reg.c:437: error: implicit declaration of function ‘wb_usb_submit_urb’
make[2]: *** [drivers/staging/winbond/./linux/wb35reg.o] Error 1

This seems to be because wb_usb_submit_urb() and alloc_urb() are in the
drivers/staging/winbond/linux/wbusb_f.h file when it is removed.

I'll go fix this up by adding another patch removing these entries.
Don't know how they got in here, odd.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/