[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20081027234246.ea5e3b8e.akpm@linux-foundation.org>
Date: Mon, 27 Oct 2008 23:42:46 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Randy Dunlap <randy.dunlap@...cle.com>
Cc: Pavel Machek <pavel@...e.cz>, "Rafael J. Wysocki" <rjw@...k.pl>,
linux-stable@...r.kernel.org,
Russell King <rmk+lkml@....linux.org.uk>,
Stanislav Brabec <utx@...guin.cz>,
kernel list <linux-kernel@...r.kernel.org>, rpurdie@...ys.net,
lenz@...wisc.edu, Dirk@...er-online.de, arminlitzel@....de,
pavel.urban@...cz, metan@...ey.karlin.mff.cuni.cz,
thommycheck@...il.com, milan@....cz
Subject: Re: [Patch 2.6.27] fix booting on Sharp Zaurus c3000
On Mon, 27 Oct 2008 09:25:12 -0700 Randy Dunlap <randy.dunlap@...cle.com> wrote:
> On Sun, 26 Oct 2008 19:41:09 +0100
> Pavel Machek <pavel@...e.cz> wrote:
>
> > Hi!
> >
> > > > > Thanks for the effort, but it looks like it did not make it, right?
> > > >
> > > > Correct - Linus was unpredictable and released 2.6.27 that evening,
> > > > four days early giving me no time to push the fix to him.
> > > >
> > > > However, it's gone in as part of the first ARM merge, so should be in
> > > > -rc1.
> > >
> > > Is it in -stable? if not, is it considered as -stable material?
> >
> > Yes, I guess it should go to stable.
> >
> > commit 69fc7eed5f56bce15b239e5110de2575a6970df4
> > Author: Dmitry Baryshkov <dbaryshkov@...il.com>
> > Date: Thu Oct 9 16:58:13 2008 +0100
> >
> > [ARM] 5300/1: fixup spitz reset during boot
> >
> > Some machines don't have the pullup/down on their reset
> > pin, so configuring the reset generating pin as input makes
> > them reset immediately. Fix that by making reset pin direction
> > configurable.
> >
> > Signed-off-by: Dmitry Baryshkov <dbaryshkov@...il.com>
> > Signed-off-by: Russell King <rmk+kernel@....linux.org.uk>
> > Signed-off-by: Pavel Machek <pavel@...e.cz>
> >
> > diff --git a/arch/arm/mach-pxa/include/mach/reset.h b/arch/arm/mach-pxa/include/mach/reset.h
> > index 9489a48..7b8842c 100644
> > --- a/arch/arm/mach-pxa/include/mach/reset.h
> > +++ b/arch/arm/mach-pxa/include/mach/reset.h
Somebody applied this.
> > @@ -10,9 +10,12 @@
> > extern unsigned int reset_status;
> > extern void clear_reset_status(unsigned int mask);
> >
> > -/*
> > - * register GPIO as reset generator
> > +/**
> > + * init_gpio_reset() - register GPIO as reset generator
> > + *
> > + * @gpio - gpio nr
> > + * @output - set gpio as out/low instead of input during normal work
>
> Use colon (':') after function parameters, not hyphen/dash.
Without doing that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists