linux-kernel - Re: [PATCH] ep93xx: fix OHCI DMA mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 Oct 2008 10:11:06 +0000
From:	Ben Dooks <ben-linux@...ff.org>
To:	Matthias Kaehlcke <matthias@...hlcke.net>, kernel@...tstofly.org,
	rmk@....linux.org.uk, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH] ep93xx: fix OHCI DMA mask

On Tue, Oct 28, 2008 at 09:19:50AM +0100, Matthias Kaehlcke wrote:
> ep93xx: Fix OHCI DMA mask
> 
> Signed-off-by: Matthias Kaehlcke <matthias@...hlcke.net>

Did this really have to go to so many people? akpm probably doesn't
need to know of this directly, Russell reads linux-arm-kernel so isn't
really a necessary CC: in this and you missed out the linux-usb list.

> --
> 
> --- linux-2.6.27.org/arch/arm/mach-ep93xx/core.c	2008-10-10 00:13:53.000000000 +0200
> +++ linux-2.6.27/arch/arm/mach-ep93xx/core.c	2008-10-28 08:05:53.000000000 +0100
> @@ -26,6 +26,7 @@
>  #include <linux/serial_core.h>
>  #include <linux/device.h>
>  #include <linux/mm.h>
> +#include <linux/dma-mapping.h>
>  #include <linux/time.h>
>  #include <linux/timex.h>
>  #include <linux/delay.h>
> @@ -450,12 +451,13 @@
>  	},
>  };
>  
> +
>  static struct platform_device ep93xx_ohci_device = {
>  	.name		= "ep93xx-ohci",
>  	.id		= -1,
>  	.dev		= {
> -		.dma_mask		= (void *)0xffffffff,
> -		.coherent_dma_mask	= 0xffffffff,
> +		.dma_mask		= &ep93xx_ohci_device.dev.coherent_dma_mask,
> +		.coherent_dma_mask	= DMA_BIT_MASK(32),
>  	},
>  	.num_resources	= ARRAY_SIZE(ep93xx_ohci_resources),
>  	.resource	= ep93xx_ohci_resources,
> 
> -- 
> Matthias Kaehlcke
> Embedded Linux Engineer
> Barcelona
> 
>             You can chain me, you can torture me, you can even
>           destroy this body, but you will never imprison my mind
>                             (Mahatma Gandhi)
>                                                                  .''`.
>     using free software / Debian GNU/Linux | http://debian.org  : :'  :
>                                                                 `. `'`
> gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4                  `-
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Ben (ben@...ff.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/