linux-kernel - Re: [PATCH] lockdep: fix irqs on/off ip tracing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081028101939.GA19628@elte.hu>
Date:	Tue, 28 Oct 2008 11:19:39 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	Steven Rostedt <srostedt@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lockdep: fix irqs on/off ip tracing


* Heiko Carstens <heiko.carstens@...ibm.com> wrote:

> From: Heiko Carstens <heiko.carstens@...ibm.com>
> 
> 81d68a96 "ftrace: trace irq disabled critical timings" added wrappers around
> trace_hardirqs_on/off_caller. However these functions use
> __builtin_return_address(0) to figure out which function actually disabled
> or enabled irqs. The result is that we save the ips of trace_hardirqs_on/off
> instead of the real caller. Not very helpful.
> However since the patch from Steven the ip already gets passed. So use that
> and get rid of __builtin_return_address(0) in these two functions.
> 
> Cc: Steven Rostedt <srostedt@...hat.com>
> Signed-off-by: Heiko Carstens <heiko.carstens@...ibm.com>
> ---
>  kernel/lockdep.c |   12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)

good catch and nice cleanup, i've applied it to tip/core/urgent, 
thanks Heiko!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/