linux-kernel - Re: [PATCH] ftrace: fix current

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.1.10.0810281429170.15590@gandalf.stny.rr.com>
Date:	Tue, 28 Oct 2008 14:32:57 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Frédéric Weisbecker <fweisbec@...il.com>
cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] ftrace: fix current_tracer error return


On Tue, 28 Oct 2008, Fr?d?ric Weisbecker wrote:

> 2008/10/28 Steven Rostedt <rostedt@...dmis.org>:
> >
> > On Tue, 28 Oct 2008, Fr?d?ric Weisbecker wrote:
> >>
> >> An that corrects the bug when I failed to assign the sched_switch tracer.
> >> Thanks Steven!
> >>
> >> Tested-by: Frederic Weisbecker <fweisbec@...il.com>
> >
> > Do you still have issues with the function tracer in the latest linux-tip?
> > If so, can you rebuild it from scratch, send me the config again, and
> > explain in detail what the issue is.
> >
> > Thanks,
> 
> I think I've caught it. See the patch I just Cc'ed you:
> ftrace: perform an initialization for ftrace to enable it

Ah! I see the issue.

My test scripts automatically set or unset /proc/sys/kernel/ftrace_enabled

I believe I wanted that to be default off when dynamic ftrace was not 
active. Currently, it really shouldn't matter, because there's a check to 
make sure that ftrace has a registered function before calling it.

That was just my preference. But if you find it less confusing, then 
having ftrace_enabled as default on even when dynamic ftrace is not 
enabled, is fine with me.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/