linux-kernel - Re: [patch 2.6.28-rc2] atmel_serial: keep clock off when it's not needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200810281251.30031.david-b@pacbell.net>
Date:	Tue, 28 Oct 2008 12:51:29 -0700
From:	David Brownell <david-b@...bell.net>
To:	"Andrew Victor" <avictor.za@...il.com>
Cc:	"Haavard Skinnemoen" <haavard.skinnemoen@...el.com>,
	lkml <linux-kernel@...r.kernel.org>,
	"Haavard Skinnemoen" <hskinnemoen@...el.com>,
	"Nicolas Ferre" <nicolas.ferre@....atmel.com>
Subject: Re: [patch 2.6.28-rc2] atmel_serial: keep clock off when it's not needed

On Tuesday 28 October 2008, Andrew Victor wrote:
> hi David,
> 
> > I verified it on AT91, where the console is normally DBGU and the
> > other USARTs do get an open().
> 
> The DBGU is part of the system peripherals, which are clocked from MCK
> and which is always enabled.

Exactly.

> Therefore I don't think this is a valid test-case.

Not for the oddball case Haavard mentioned, no:  the console port
being something the boot loader wasn't using, which couldn't show
the early boot messages (before console setup) in any case.  Those
kinds of systems aren't especially debuggable (it's JTAG or nothing).

I don't have any issue with getting that fixed too ... but unless
someone has a platform that relies on that case (or can be made to
do so, for testing), then it's hard for me to worry about it!

- Dave

> 
> Regards,
>   Andrew Victor
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/