linux-kernel - Re: [PATCH] regression: vmalloc easily fail.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adad4hkml7b.fsf@cisco.com>
Date:	Tue, 28 Oct 2008 15:03:20 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Arjan van de Ven <arjan@...radead.org>
Cc:	Avi Kivity <avi@...hat.com>, Glauber Costa <glommer@...hat.com>,
	linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
	aliguori@...emonkey.ws, npiggin@...e.de,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Krzysztof Helt <krzysztof.h1@...zta.fm>
Subject: Re: [PATCH] regression: vmalloc easily fail.

 > I suspect it's a case of off-by-one... ALIGN() might round down, and
 > the "+ (PAGE_SIZE-1)" was there to make it round up.
 > Except for that missing -1 ...

ALIGN() has always rounded up, at least back to 2.4.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/