linux-kernel - Re: [PATCH] linux/timex.h: cleanup for userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1aad82fa0810272031p3ab3bc1bn3b6295abe8b218ae@mail.gmail.com>
Date:	Mon, 27 Oct 2008 23:31:50 -0400
From:	"Mike Frysinger" <vapier@...too.org>
To:	"Andrew Morton" <akpm@...ux-foundation.org>
Cc:	"Roman Zippel" <zippel@...ux-m68k.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] linux/timex.h: cleanup for userspace

On Mon, Oct 27, 2008 at 11:28 PM, Andrew Morton wrote:
> On Sun, 26 Oct 2008 06:37:31 -0400 Mike Frysinger wrote:
>> Move all the kernel-specific defines and includes into the __KERNEL__
>> section so that they don't get leaked into userspace.
>
> checkpatch correctly instructs us to use linux/param.h, not asm/param.h.

i was just moving around existing code in an attempt to minimize
possible breakage ;)

> --- a/include/linux/timex.h~linux-timexh-cleanup-for-userspace-checkpatch-fixes
> +++ a/include/linux/timex.h
> @@ -165,8 +165,8 @@ struct timex {
>  #ifdef __KERNEL__
>  #include <linux/compiler.h>
>  #include <linux/types.h>
> +#include <linux/param.h>
>
> -#include <asm/param.h>
>  #include <asm/timex.h>
>
>  /*
> _
>
> seems Obviously Safe to me.  Do you agree?

Acked-by: Mike Frysinger <vapier@...too.org>
-mike
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/