linux-kernel - Re: ftrace: fix depends

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081029091857.GA4414@osiris.boeblingen.de.ibm.com>
Date:	Wed, 29 Oct 2008 10:18:57 +0100
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	Ingo Molnar <mingo@...e.hu>, Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org, lethal@...ux-sh.org
Subject: Re: ftrace: fix depends

On Tue, Oct 28, 2008 at 06:02:41PM +0000, Linux Kernel Mailing List wrote:
> Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=c2db8054c1eaf99983d8deee347876b01c26c2cf
> Commit:     c2db8054c1eaf99983d8deee347876b01c26c2cf
> Parent:     bd95b88d9e51fcbf392a7e90338a8fcc3499cbd6
> Author:     Steven Rostedt <rostedt@...dmis.org>
> AuthorDate: Mon Oct 6 19:06:11 2008 -0400
> Committer:  Ingo Molnar <mingo@...e.hu>
> CommitDate: Mon Oct 20 18:27:02 2008 +0200
> 
>     ftrace: fix depends
>     
>     A lot of tracers have HAVE_FTRACE as a dependent config where it
>     really should not. The HAVE_FTRACE is a misnomer (soon to be fixed)
>     and describes if the architecture has the function tracer (mcount)
>     implemented. The ftrace infrastructure is implemented in all archs.
>     
>     Signed-off-by: Steven Rostedt <srostedt@...hat.com>
>     Signed-off-by: Ingo Molnar <mingo@...e.hu>

Hmm... this is not very true. I count three architectures which have this
implemented plus arm with a 'depends on' plus sh with the broken HAVE_FTRACE
instead of HAVE_FUNCTION_TRACER.

All other architectures will see something like this:

kernel/built-in.o: In function `tracer_alloc_buffers':
trace.c:(.init.text+0x42c2): undefined reference to `nop_trace'
trace.c:(.init.text+0x42ec): undefined reference to `nop_trace'
make: *** [.tmp_vmlinux1] Error 1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/