linux-kernel - Re: [linux-pm] Freezer: Don't count threads waiting for frozen filesystems.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0810291122220.2189-100000@iolanthe.rowland.org>
Date:	Wed, 29 Oct 2008 11:28:34 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Miklos Szeredi <miklos@...redi.hu>
cc:	rjw@...k.pl, <linux-kernel@...r.kernel.org>,
	<ncunningham@...a.org.au>, <linux-pm@...ts.linux-foundation.org>
Subject: Re: [linux-pm] Freezer: Don't count threads waiting for frozen
 filesystems.

On Wed, 29 Oct 2008, Miklos Szeredi wrote:

> Actually I was thinking of an rw-semaphore, not a mutex.  But yeah
> that still has scalability problems.  But it could be done with custom
> locking primitives, optimized for this case:
> 
>    suspend_disable();
>    /* driver stuff */
>    suspend_enable();

Yes, it could be done.  And the overhead could be minimized by using
per-CPU variables.  It would still be an awful lot of work, and easy to
get wrong.

> > The problem with unrestricted freezing shows up when you freeze tasks
> > that hold a mutex or other sort of lock.  If this mutex is needed later
> > on for suspending a device then the suspend will hang, because a frozen
> > task can't release any mutexes.
> 
> I did a random sampling of ->suspend() callbacks, and they don't seem
> to be taking mutexes.  Does that happen at all?

It does, particularly among drivers that do runtime PM, which is 
becoming more and more important.

Besides, suspend has to synchronize with I/O somehow.  Right now that 
is handled by making suspend wait until no tasks are doing I/O (because 
they are all frozen).  If you allow tasks to be frozen at more or less 
arbitrary times, while holding arbitrary locks, then you may end up 
freezing a task that's in the middle of I/O.  That should certainly 
block the suspend (not to mention messing up the I/O operation).

> Did anybody ever try modifying the freezer for suspend (not
> hibernate), so that it allows tasks not in running state to freeze?
> If not, I think that's an experiment worth doing.

What happens if the reason the task isn't running is because it's 
waiting for I/O to complete?  I just don't think this can be made to 
work.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/