linux-kernel - [PATCH] corruption checker: print the DMI board name on corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081029092756.1e441b80@infradead.org>
Date:	Wed, 29 Oct 2008 09:27:56 -0700
From:	Arjan van de Ven <arjan@...radead.org>
To:	torvalds@...ux-foundation.org
Cc:	mingo@...e.hu, linux-kernel@...r.kernel.org
Subject: [PATCH] corruption checker: print the DMI board name on corruption

Hi Linus,

would you consider merging this patch for 2.6.28 still?
Without this patch, kerneloops.org only gets to see THAT corruption
happens, but doesn't have information about what kind of system the
corruption is happening on.. (which is the useful part to make a
DMI blacklist).

So far we have 1 such report in kerneloops.org but it's useless... no
system information.



>From c66993517ac861964d6968d3672f88b3b69e29ce Mon Sep 17 00:00:00 2001
From: Arjan van de Ven <arjan@...ux.intel.com>
Date: Wed, 29 Oct 2008 09:24:44 -0700
Subject: [PATCH] corruption checker: print the DMI board name on corruption

when the memory corruptor checker hits (as it has done now based on
kerneloops.org data), it would be extremely useful to know the DMI board
name so we can add a blacklist for such a machine... without having to ask
the user for lots of extra info.

Signed-off-by: Arjan van de Ven <arjan@...ux.intel.com>
---
 arch/x86/kernel/setup.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 0fa6790..d57fee2 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -697,6 +697,7 @@ void check_for_bios_corruption(void)
 {
 	int i;
 	int corruption = 0;
+	const char *board;
 
 	if (!memory_corruption_check)
 		return;
@@ -715,7 +716,11 @@ void check_for_bios_corruption(void)
 		}
 	}
 
-	WARN(corruption, KERN_ERR "Memory corruption detected in low memory\n");
+	board = dmi_get_system_info(DMI_PRODUCT_NAME);
+	if (!board)
+		board = "";
+	WARN_ONCE(corruption, KERN_ERR "Memory corruption detected in low memory\nBoard name: %s\n",
+		board);
 }
 
 static void periodic_check_for_corruption(unsigned long data)
-- 
1.5.5.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/