linux-kernel - Re: [PATCH] memory hotplug: fix page_zone() calculation in test_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4908A4CC.3000300@austin.ibm.com>
Date:	Wed, 29 Oct 2008 13:00:44 -0500
From:	Nathan Fontenot <nfont@...tin.ibm.com>
To:	gerald.schaefer@...ibm.com
CC:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, schwidefsky@...ibm.com,
	heiko.carstens@...ibm.com, kamezawa.hiroyu@...fujitsu.com,
	y-goto@...fujitsu.com, dave@...ux.vnet.ibm.com
Subject: Re: [PATCH] memory hotplug: fix page_zone() calculation in	test_pages_isolated()

Looks like you beat me to it, and with a nicer fix too.

Gerald Schaefer wrote:
> From: Gerald Schaefer <gerald.schaefer@...ibm.com>
> 
> My last bugfix here (adding zone->lock) introduced a new problem: Using
> page_zone(pfn_to_page(pfn)) to get the zone after the for() loop is wrong.
> pfn will then be >= end_pfn, which may be in a different zone or not
> present at all. This may lead to an addressing exception in page_zone()
> or spin_lock_irqsave().
> 
> Now I use __first_valid_page() again after the loop to find a valid page
> for page_zone().
> 
> Signed-off-by: Gerald Schaefer <gerald.schaefer@...ibm.com>

Acked-by: Nathan Fontenot <nfont@...tin.ibm.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/