linux-kernel - Re: [PATCH 01/11] ftrace: handle generic arch calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081029203133.GC1816@cs181140183.pp.htv.fi>
Date:	Wed, 29 Oct 2008 22:31:33 +0200
From:	Adrian Bunk <bunk@...nel.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Sam Ravnborg <sam@...nborg.org>,
	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Abhishek Sagar <sagar.abhishek@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Steven Rostedt <srostedt@...hat.com>
Subject: Re: [PATCH 01/11] ftrace: handle generic arch calls

On Wed, Oct 29, 2008 at 04:23:34PM -0400, Steven Rostedt wrote:
> 
> On Wed, 29 Oct 2008, Adrian Bunk wrote:
> > > > 
> > > > Since x86 is the ambiguous case, I made it the one that would be converted 
> > > > to i386 or x86_64 since those could be passed in directly.
> > > The trick is usually to replace use of ARCH with SRCARCH.
> > 
> > That won't help - what he wants to know is whether he's on 32bit or
> > on 64bit.
> 
> I will still get the "bits" parameter.

Ah, I didn't get this bit from your email.

> The issue that we are talking about 
> here is that I have this ugly if statement that deals with the fact that 
> we can get "x86", "x86_64" or "i386" passed in as the ARCH. I'm guessing 
> if we switch ARCH to SRCARCH then we can just test against x86 and bits?

Yes.

And as a bonus you will automatically get the correct output when you'll 
add support for UML.

> -- Steve

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/