| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20081029210149.GA6820@joi> Date: Wed, 29 Oct 2008 22:16:29 +0100 From: Marcin Slusarz <marcin.slusarz@...il.com> To: Christoph Hellwig <hch@...radead.org> Cc: Andrew Morton <akpm@...ux-foundation.org>, Linus Torvalds <torvalds@...ux-foundation.org>, Matthew Wilcox <willy@...ux.intel.com>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] Rename DECLARE_MUTEX to DEFINE_SEMAPHORE On Sun, Oct 26, 2008 at 12:41:18PM -0400, Christoph Hellwig wrote: > On Sun, Oct 26, 2008 at 01:06:14PM +0100, Marcin Slusarz wrote: > > DECLARE_MUTEX is doubly misleading name (it actually _defines_ struct > > _semaphore_ initialized to 1) and it can be confused with DEFINE_MUTEX > > (which defines real struct mutex). Rename it. > > NACK. It describes reasonably well what it does. Of course that's a > little confusing as we now have a specialized primitive to just do that. > > If the name annoys you enough so that you want to get rid of it help > converting the remaining instances to struct mutex and DEFINE_MUTEX(). Changing the name of DECLARE_MUTEX (to something which tells us what it really does) will increase visibility of semaphore uses, don't you think? And more visibility means more patches removing its uses. Marcin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists