linux-kernel - Re: mmc: struct device - replace bus_id with dev_name(), dev_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081030100957.6cba7174@mjolnir.drzeus.cx>
Date:	Thu, 30 Oct 2008 10:09:57 +0100
From:	Pierre Ossman <drzeus@...eus.cx>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	Kay Sievers <kay.sievers@...y.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Greg KH <greg@...ah.com>
Subject: Re: mmc: struct device - replace bus_id with dev_name(),
 dev_set_name()

On Wed, 29 Oct 2008 18:48:04 -0700
Harvey Harrison <harvey.harrison@...il.com> wrote:

> 
> A lot of these helpers don't seem to add that much, would you care for
> a patch removing them Pierre?
> 
> Specifically sdio_func_id, sdio_get/set_drvdata don't have that many
> users.
> 
> mmc_hostname has a lot of users, but if you're agreeable, I could
> take a crack at that too.
> 

As Marcel said, they provide a nice abstraction (even if it is indeed
a bit silly to have wrappers around wrappers around ..). It also tends
to make the code a bit more readable.

Rgds
-- 
     -- Pierre Ossman

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)