linux-kernel - Re: [PATCH] corruption checker: print the DMI board name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 30 Oct 2008 12:06:53 +0100
From:	Pavel Machek <pavel@...e.cz>
To:	Arjan van de Ven <arjan@...radead.org>
Cc:	mingo@...e.hu, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] corruption checker: print the DMI board name

> 
> >From 4f829eef5a31b68a0cbaf83a75ac8b0a1ed05afb Mon Sep 17 00:00:00 2001
> From: Arjan van de Ven <arjan@...ux.intel.com>
> Date: Wed, 29 Oct 2008 09:13:23 -0700
> Subject: [PATCH] corruption checker: print the DMI board name
> 
> when the memory corruptor checker hits (as it has done now based on kerneloops.org data),
> it would be extremely useful to know the DMI board name so we can add a blacklist for
> such a machine... without having to ask the user for lots of extra info.

I'm not sure if blacklisting whole brand for one case of bit
corruption is fair -- perhaps the memory was overheating?

  
> Signed-off-by: Arjan van de Ven <arjan@...ux.intel.com>

But ACK -- we certainly want to see the data.

> ---
>  arch/x86/kernel/check.c |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/check.c b/arch/x86/kernel/check.c
> index 2ac0ab7..f952182 100644
> --- a/arch/x86/kernel/check.c
> +++ b/arch/x86/kernel/check.c
> @@ -2,6 +2,7 @@
>  #include <linux/sched.h>
>  #include <linux/kthread.h>
>  #include <linux/workqueue.h>
> +#include <linux/dmi.h>
>  #include <asm/e820.h>
>  #include <asm/proto.h>
>  
> @@ -113,6 +114,7 @@ void check_for_bios_corruption(void)
>  {
>  	int i;
>  	int corruption = 0;
> +	const char *board;
>  
>  	if (!memory_corruption_check)
>  		return;
> @@ -131,7 +133,11 @@ void check_for_bios_corruption(void)
>  		}
>  	}
>  
> -	WARN_ONCE(corruption, KERN_ERR "Memory corruption detected in low memory\n");
> +	board = dmi_get_system_info(DMI_PRODUCT_NAME);
> +	if (!board)
> +		board = "";
> +	WARN_ONCE(corruption, KERN_ERR "Memory corruption detected in low memory\nBoard name: %s\n",
> +		board);
>  }
>  
>  static void check_corruption(struct work_struct *dummy);

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/