linux-kernel - Re: [PATCH] Power Management support requires RTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081030092255.948a7063.randy.dunlap@oracle.com>
Date:	Thu, 30 Oct 2008 09:22:55 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Yoichi Yuasa <yoichi_yuasa@...peaks.co.jp>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] Power Management support requires RTC_CLASS

On Fri, 31 Oct 2008 00:04:07 +0900 Yoichi Yuasa wrote:

> kernel/built-in.o: In function `test_wakealarm':
> linux/kernel/power/main.c:619: undefined reference to `rtc_read_time'
> linux/kernel/power/main.c:619: relocation truncated to fit: R_MIPS_26 against `rtc_read_time'
> linux/kernel/power/main.c:630: undefined reference to `rtc_set_alarm'
> linux/kernel/power/main.c:630: relocation truncated to fit: R_MIPS_26 against `rtc_set_alarm'
> linux/kernel/power/main.c:654: undefined reference to `rtc_set_alarm'
> linux/kernel/power/main.c:654: relocation truncated to fit: R_MIPS_26 against `rtc_set_alarm'
> kernel/built-in.o: In function `test_suspend':
> linux/kernel/power/main.c:718: undefined reference to `rtc_class_open'
> linux/kernel/power/main.c:718: relocation truncated to fit: R_MIPS_26 against `rtc_class_open'
> linux/kernel/power/main.c:726: undefined reference to `rtc_class_close'
> linux/kernel/power/main.c:726: relocation truncated to fit: R_MIPS_26 against `rtc_class_close'
> kernel/built-in.o: In function `valid_state':
> linux/kernel/power/main.c:403: undefined reference to `rtc_class'
> kernel/built-in.o: In function `test_suspend':
> linux/kernel/power/main.c:716: undefined reference to `rtc_class'
> 
> Signed-off-by: Yoichi Yuasa <yoichi_yuasa@...peaks.co.jp>
> 
> diff -pruN -X /home/yuasa/Memo/dontdiff linux-orig/kernel/power/Kconfig linux/kernel/power/Kconfig
> --- linux-orig/kernel/power/Kconfig	2008-10-22 09:41:32.154425163 +0900
> +++ linux/kernel/power/Kconfig	2008-10-22 11:04:48.230018848 +0900
> @@ -1,6 +1,7 @@
>  config PM
>  	bool "Power Management support"
>  	depends on !IA64_HP_SIM
> +	select RTC_CLASS
>  	---help---
>  	  "Power Management" means that parts of your computer are shut
>  	  off or put into a power conserving "sleep" mode if they are not
> --

That should only be needed for the code block that is surrounded by

#ifdef CONFIG_PM_TEST_SUSPEND
...
#endif /* CONFIG_PM_TEST_SUSPEND */

and the Kconfig file already contains

config PM_TEST_SUSPEND
	bool "Test suspend/resume and wakealarm during bootup"
	depends on SUSPEND && PM_DEBUG && RTC_LIB=y

so maybe that needs to be changed to use RTC_CLASS.  I dunno.

---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/