linux-kernel - Re: [RFC] B+Tree library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 30 Oct 2008 18:58:44 +0100
From:	Jörn Engel <joern@...fs.org>
To:	Pavel Machek <pavel@...e.cz>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [RFC] B+Tree library

On Thu, 30 October 2008 18:43:00 +0100, Pavel Machek wrote:
> 
> + * Disks have fulfilled the prerequite for a long time.  More recently DRAM
> 
> prerequisite?

In the paragraph above:

+ * B+Trees can be used similar to Linux radix trees (which don't have anything
+ * in common with textbook radix trees, beware).  Prerequisite for them working
+ * well is that access to a random tree node is much faster than a large number
+ * of operations within each node.

> +#define MAX(a, b) ((a) > (b) ? (a) : (b))
> 
> We already have that in the headers somewhere.

Except that min/max in include/linux/kernel.h have some type-safety
added.  In this particular case that is actually a disadvantage:
  CC      lib/btree.o
  lib/btree.c:56: error: braced-group within expression allowed only inside a function
  lib/btree.c:62: error: braced-group within expression allowed only inside a function
  lib/btree.c:67: error: braced-group within expression allowed only inside a function

So I need something more stupid. :)

Jörn

-- 
It does not require a majority to prevail, but rather an irate,
tireless minority keen to set brush fires in people's minds.
-- Samuel Adams
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/