linux-kernel - Re: [PATCH] x86: simplify X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 30 Oct 2008 19:14:45 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Jan Beulich <jbeulich@...ell.com>
Cc:	tglx@...utronix.de, linux-kernel@...r.kernel.org, hpa@...or.com
Subject: Re: [PATCH] x86: simplify X86_MPPARSE config option


* Jan Beulich <jbeulich@...ell.com> wrote:

> >>> Ingo Molnar <mingo@...e.hu> 30.10.08 11:51 >>>
> >
> >* Jan Beulich <jbeulich@...ell.com> wrote:
> >
> >> Signed-off-by: Jan Beulich <jbeulich@...ell.com>
> >> 
> >> ---
> >>  arch/x86/Kconfig |   12 ++----------
> >>  1 file changed, 2 insertions(+), 10 deletions(-)
> >> 
> >> --- linux-2.6.28-rc2/arch/x86/Kconfig	2008-10-30 11:03:18.000000000 +0100
> >> +++ 2.6.28-rc2-x86-kconfig-cleanup/arch/x86/Kconfig	2008-10-21 13:57:07.000000000 +0200
> >> @@ -235,21 +235,13 @@ config X86_FIND_SMP_CONFIG
> >>  	def_bool y
> >>  	depends on X86_MPPARSE || X86_VOYAGER
> >>  
> >> -if ACPI
> >>  config X86_MPPARSE
> >> -	def_bool y
> >> -	bool "Enable MPS table"
> >> +	bool "Enable MPS table" if ACPI
> >> +	default y
> >>  	depends on X86_LOCAL_APIC
> >>  	help
> >>  	  For old smp systems that do not have proper acpi support. Newer systems
> >>  	  (esp with 64bit cpus) with acpi support, MADT and DSDT will override it
> >> -endif
> >> -
> >> -if !ACPI
> >> -config X86_MPPARSE
> >> -	def_bool y
> >> -	depends on X86_LOCAL_APIC
> >> -endif
> >
> >hm, that's not an equivalent change. But i guess we can do this, it 
> >sure looks like a cleaner construct.
> 
> Why is it not equivalent (apart from the help portion, which doesn't 
> matter when the prompt isn't visible)?

you are right, it's equivalent - the "if ACPI" makes interactivity 
(the prompt) conditional, not the option.

applied to tip/x86/cleanups, thanks!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/