linux-kernel - Re: staging: me4000 and relation to other data acquisition devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081030000423.GB23359@suse.de>
Date:	Wed, 29 Oct 2008 17:04:23 -0700
From:	Greg KH <gregkh@...e.de>
To:	Shawn Bohrer <shawn.bohrer@...il.com>
Cc:	David Schleef <ds@...leef.org>,
	Frank Mori Hess <fmhess@...rs.sourceforge.net>,
	Ian Abbott <abbotti@....co.uk>, linux-kernel@...r.kernel.org,
	Wolfgang Beiter <w.beiter@....at>
Subject: Re: staging: me4000 and relation to other data acquisition devices

On Wed, Oct 29, 2008 at 12:37:19PM -0500, Shawn Bohrer wrote:
> On Tue, Oct 28, 2008 at 09:34:56AM -0700, Greg KH wrote:
> > On Tue, Oct 28, 2008 at 10:49:18AM -0500, Shawn Bohrer wrote:
> > > I have some questions about the user-kernel interface of the me4000
> > > driver.  From my looking through the code it seems specific to the
> > > me4000 hardware which does concern me since there are hundreds of
> > > different data acquisition devices from many different vendors.  In my
> > > opinion it would beneficial if at the very least all of these devices
> > > shared a common device interface.
> > 
> > I totally agree.
> > 
> > The me4000's user interface is not "set in stone" and needs to be fixed
> > up in order to move into the main kernel tree.
> > 
> > > Additionally there is the out of tree Comedi project:
> > > 
> > > http://comedi.org
> > > 
> > > Which supports this hardware, and many more, with a generic device
> > > interface.  There may be other reason not to merge Comedi (I know they
> > > have a desire to maintain support of their RT support), but I can't help
> > > but feel that merging the me4000 driver without thinking about the
> > > hundreds of other devices out there is a mistake.
> > 
> > I would love to get comedi into the kernel tree.  People have talked
> > about it for years now, is it time for me to just take a snapshot and
> > place it in drivers/staging/ for everyone to then work on cleaning up
> > properly?
> 
> I think that is up to the Comedi maintainers.  If the Comedi maintainers
> do not want to head in that direction, I'm sure the me4000 driver
> currently in drivers/staging/ would benefit from their review.

Ok, David, Frank, Ian, what do you think?

I can take a snapshot of the development tree right now, put it into
drivers/staging/comedi/ and then work with you all, and the hundreds of
kernel developers to get the code into "mergable" shape to get it merged
into the main kernel tree.

By moving it into the staging tree now, you get the benifit of those
other developers helping out with this effort, and the benifit of the
code being added to all the distros and more users using it, and not
having to build and install their own versions.

I'll be glad to do this, and maintain it if need be.  Your codebase is
great, and it provides a much needed standard interface for this type of
device for Linux.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/