linux-kernel - Re: [PATCH] kernel/cpu.c: Section mismatch warning fix.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081030182601.GE14102@elte.hu>
Date:	Thu, 30 Oct 2008 19:26:01 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Rakib Mullick <rakib.mullick@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] kernel/cpu.c: Section mismatch warning fix.


* Rakib Mullick <rakib.mullick@...il.com> wrote:

>  LD      kernel/built-in.o
> WARNING: kernel/built-in.o(.text+0xb7c8): Section mismatch in
> reference from the function notify_cpu_starting() to the variable
> .cpuinit.data:cpu_chain
> The function notify_cpu_starting() references
> the variable __cpuinitdata cpu_chain.
> This is often because notify_cpu_starting lacks a __cpuinitdata
> annotation or the annotation of cpu_chain is wrong.
> 
> This patch fixes the above section mismatch warning. If anything else
> please notice.
> Thanks.
> 
> Signed-off-by: Md.Rakib H. Mullick <rakib.mullick@...il.com>
> 
> --- linux-2.6-orig/kernel/cpu.c	2008-10-28 20:52:38.000000000 +0600
> +++ linux-2.6/kernel/cpu.c	2008-10-28 22:46:22.000000000 +0600
> @@ -462,7 +462,7 @@ out:
>   * It must be called by the arch code on the new cpu, before the new cpu
>   * enables interrupts and before the "boot" cpu returns from __cpu_up().
>   */
> -void notify_cpu_starting(unsigned int cpu)
> +void __cpuinit notify_cpu_starting(unsigned int cpu)
>  {
>  	unsigned long val = CPU_STARTING;

you've tested that on x86, right? Have you checked/reviewed all the 
non-x86 architecture codepaths:

 ./arch/m32r/kernel/smpboot.c:	notify_cpu_starting(cpu_id);
 ./arch/cris/arch-v32/kernel/smp.c:	notify_cpu_starting(cpu);
 ./arch/s390/kernel/smp.c:	 notify_cpu_starting(smp_processor_id());
 ./arch/x86/mach-voyager/voyager_smp.c:	notify_cpu_starting(cpuid);
 ./arch/x86/kernel/smpboot.c:	notify_cpu_starting(cpuid);
 ./arch/mips/kernel/smp.c:	notify_cpu_starting(cpu);
 ./arch/sparc64/kernel/smp.c:	notify_cpu_starting(cpuid);
 ./arch/ia64/kernel/smpboot.c:	notify_cpu_starting(cpuid);
 ./arch/um/kernel/smp.c:	notify_cpu_starting(cpu);
 ./arch/sparc/kernel/sun4d_smp.c:	notify_cpu_starting(cpuid);
 ./arch/sparc/kernel/sun4m_smp.c:	notify_cpu_starting(cpuid);
 ./arch/powerpc/kernel/smp.c:	notify_cpu_starting(cpu);
 ./arch/alpha/kernel/smp.c:	notify_cpu_starting(cpuid);
 ./arch/sh/kernel/smp.c:	notify_cpu_starting(smp_processor_id());
 ./arch/arm/kernel/smp.c:	notify_cpu_starting(cpu);

to make sure that they never use this function after free_initmem()?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/