linux-kernel - Re: [PATCH 3/7] w35und: remove unused ->ShutDowned member from struct LOCAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081030191754.GH22185@elf.ucw.cz>
Date:	Thu, 30 Oct 2008 20:17:54 +0100
From:	Pavel Machek <pavel@...e.cz>
To:	Pekka Enberg <penberg@...helsinki.fi>
Cc:	greg@...ah.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/7] w35und: remove unused ->ShutDowned member from
	struct LOCAL_PARA

On Thu 2008-10-30 18:12:03, Pekka Enberg wrote:
> It's not actually read by anyone so we might as well remove it.

Acked-by: Pavel Machek <pavel@...e.cz>

> Signed-off-by: Pekka Enberg <penberg@...helsinki.fi>
> ---
>  drivers/staging/winbond/localpara.h |    1 -
>  drivers/staging/winbond/wbusb.c     |    6 ------
>  2 files changed, 0 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/winbond/localpara.h b/drivers/staging/winbond/localpara.h
> index a308ac2..607bb05 100644
> --- a/drivers/staging/winbond/localpara.h
> +++ b/drivers/staging/winbond/localpara.h
> @@ -149,7 +149,6 @@ typedef struct LOCAL_PARA
>  
>      //// power-save variables
>      u8  		  	iPowerSaveMode;     // 0 indicates it is on, 1 indicates it is off
> -	u8			ShutDowned;
>  	u8			ATIMmode;
>  	u8			ExcludeUnencrypted;
>  
> diff --git a/drivers/staging/winbond/wbusb.c b/drivers/staging/winbond/wbusb.c
> index 673875d..0f70101 100644
> --- a/drivers/staging/winbond/wbusb.c
> +++ b/drivers/staging/winbond/wbusb.c
> @@ -220,9 +220,6 @@ static unsigned char wb35_hw_init(struct ieee80211_hw *hw)
>  	pHwData = &priv->sHwData;
>  	hal_set_phy_type( pHwData, RF_DECIDE_BY_INF );
>  
> -	// Initial Software variable
> -	priv->sLocalPara.ShutDowned = false;
> -
>  	//added by ws for wep key error detection
>  	priv->sLocalPara.bWepKeyError= false;
>  	priv->sLocalPara.bToSelfPacketReceived = false;
> @@ -424,9 +421,6 @@ void packet_came(struct ieee80211_hw *hw, char *pRxBufferAddress, int PacketSize
>  
>  static void wb35_hw_halt(struct wbsoft_priv *adapter)
>  {
> -	//---------------------
> -	adapter->sLocalPara.ShutDowned = true;
> -
>  	Mds_Destroy( adapter );
>  
>  	// Turn off Rx and Tx hardware ability

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/