linux-kernel - Re: [PATCH] fix ACPI induced voyager compile failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 30 Oct 2008 22:58:19 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	James Bottomley <James.Bottomley@...senPartnership.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fix ACPI induced voyager compile failure


* James Bottomley <James.Bottomley@...senPartnership.com> wrote:

> >From c339b7cdc39399855ec07dfbff67304f9c7fa49a Mon Sep 17 00:00:00 2001
> From: James Bottomley <James.Bottomley@...senPartnership.com>
> Date: Wed, 29 Oct 2008 10:58:13 -0500
> Subject: [VOYAGER] x86: don't pull asm/acpi.h into fixmap_32.h
> 
> If it's not needed it causes compile failures.
> 
> Signed-off-by: James Bottomley <James.Bottomley@...senPartnership.com>
> ---
>  arch/x86/include/asm/fixmap_32.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/x86/include/asm/fixmap_32.h b/arch/x86/include/asm/fixmap_32.h
> index 09f29ab..c3302ee 100644
> --- a/arch/x86/include/asm/fixmap_32.h
> +++ b/arch/x86/include/asm/fixmap_32.h
> @@ -25,7 +25,9 @@ extern unsigned long __FIXADDR_TOP;
>  
>  #ifndef __ASSEMBLY__
>  #include <linux/kernel.h>
> +#ifdef CONFIG_ACPI
>  #include <asm/acpi.h>
> +#endif

hm, that's quite ugly - such headers are supposed to be safe even if 
CONFIG_APIC is not turned on.

What kind of compiler failures are you getting, could you send the 
.config that triggers it? I'm curious what the real cause of the build 
failure is - the #ifdef you are adding seems to fix a symptom, not a 
real bug - and maybe we can do a better fix.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/