linux-kernel - Re: mmc: struct device - replace bus_id with dev_name(), dev_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1225343754.5496.14.camel@brick>
Date:	Wed, 29 Oct 2008 22:15:54 -0700
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	Marcel Holtmann <marcel@...tmann.org>
Cc:	Kay Sievers <kay.sievers@...y.org>,
	Pierre Ossman <drzeus@...eus.cx>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Greg KH <greg@...ah.com>
Subject: Re: mmc: struct device - replace bus_id with dev_name(),
 dev_set_name()

On Thu, 2008-10-30 at 05:37 +0100, Marcel Holtmann wrote:
> Hi Harvey,
> >
> > A lot of these helpers don't seem to add that much, would you care for
> > a patch removing them Pierre?
> >
> > Specifically sdio_func_id, sdio_get/set_drvdata don't have that many
> > users.
> 
> I prefer if we keep them. Since they take the proper parameter.  
> Otherwise the driver has to always got func->dev for everything. Most  
> SDIO drivers care of the function and not about the struct device  
> underneath it.
> 

Sure, it just seemed odd to have a wrapper around a wrapper.

Cheers,

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/