linux-kernel - Re: [dm-devel] [PATCH] Add gfp_mask to bio_integrity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1hc6s3l4g.fsf@sermon.lab.mkp.net>
Date:	Fri, 31 Oct 2008 10:16:47 -0400
From:	"Martin K. Petersen" <martin.petersen@...cle.com>
To:	device-mapper development <dm-devel@...hat.com>
Cc:	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Kiyoshi Ueda <k-ueda@...jp.nec.com>,
	linux-kernel@...r.kernel.org, Alasdair G Kergon <agk@...hat.com>,
	Jens Axboe <jens.axboe@...cle.com>
Subject: Re: [dm-devel] [PATCH] Add gfp_mask to bio_integrity_clone()

>>>>> "Jun'ichi" == Jun'ichi Nomura <j-nomura@...jp.nec.com> writes:

Jun'ichi> What do you think about adding gfp_mask parameter to
Jun'ichi> bio_integrity_clone() like the attached patch?

Jun'ichi> It also seems natural to inherit gfp_mask from bio_clone
Jun'ichi> when bio_integrity_clone is called from it.  Since
Jun'ichi> bio_clone() is the only caller of bio_integrity_clone() in
Jun'ichi> 2.6.28-rc2 and all in-tree callers of bio_clone() are using
Jun'ichi> GFP_NOIO, the patch does nothing other than changing the
Jun'ichi> interface.

Looks good to me.  I'll update the non-multipath DM bits accordingly.

Acked-by: Martin K. Petersen <martin.petersen@...cle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/