linux-kernel - Re: 2.6.28-rc2 hates my e1000e

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0810310839380.21084@nehalem.linux-foundation.org>
Date:	Fri, 31 Oct 2008 08:44:52 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Yinghai Lu <yinghai@...nel.org>
cc:	Jonathan Corbet <corbet@....net>, Ingo Molnar <mingo@...e.hu>,
	Robert Hancock <hancockr@...w.ca>,
	e1000-devel@...ts.sourceforge.net,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: 2.6.28-rc2 hates my e1000e



On Fri, 31 Oct 2008, Linus Torvalds wrote:
> 
> Jonathan, what do things look like with the simple "use 'expand_to_fit'" 
> patch instead, ie something like this:

And by "something like this", I obviously _really_ meant "something 
almost, but not entirely, unlike this".

> -			reserve_region_with_split(&iomem_resource, res->start, res->end, res->name);
> +			insert_resource_expand_to_fit(&iomem_resource, res->start, res->end, res->name);

The "insert_resource_expand_to_fit()" calling convention is much simpler, 
and it should be just

	insert_resource_expand_to_fit(&iomem_resource, res);

which has the downside (?) that it will actually _modify_ the resource as 
it expands it to fit. Of course, it's not like we don't do that in other 
places too (ie the "sanitize" phase), so I don't think it's much of a real 
downside.

Anyway, I'm not appending a fixed patch, becuase the fix is so trivial as 
to be more easily done by hand.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/