linux-kernel - Re: [PATCH] driver core: Use 'ret' variable in unregister_dynamic_debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 31 Oct 2008 16:40:24 -0400
From:	Jason Baron <jbaron@...hat.com>
To:	Johann Felix Soden <johfel@....de>
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] driver core: Use 'ret' variable in
	unregister_dynamic_debug_module

On Thu, Oct 30, 2008 at 10:44:39PM +0100, Johann Felix Soden wrote:
> From: Johann Felix Soden <johfel@...rs.sourceforge.net>
> 
> The 'ret' variable is assigned, but not used in the return statement. Fix this.
> 
> Signed-off-by: Johann Felix Soden <johfel@...rs.sourceforge.net>
> CC: Jason Baron <jbaron@...hat.com>
> ---
>  lib/dynamic_printk.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/dynamic_printk.c b/lib/dynamic_printk.c
> index d83660f..d0fd0e4 100644
> --- a/lib/dynamic_printk.c
> +++ b/lib/dynamic_printk.c
> @@ -135,7 +135,7 @@ int unregister_dynamic_debug_module(char *mod_name)
>  	nr_entries--;
>  out:
>  	up(&debug_list_mutex);
> -	return 0;
> +	return ret;
>  }
>  EXPORT_SYMBOL_GPL(unregister_dynamic_debug_module);
>  

looks good to me.

Acked-by: Jason Baron <jbaron@...hat.com>

thanks,

-Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/