| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <Pine.LNX.4.64.0811011012020.21848@blonde.site> Date: Sat, 1 Nov 2008 10:33:55 +0000 (GMT) From: Hugh Dickins <hugh@...itas.com> To: Li Xiaodong <lixd@...fujitsu.com> cc: linux-kernel@...r.kernel.org Subject: Re: [PATCH]swap-zero-page-bug On Wed, 29 Oct 2008, Li Xiaodong wrote: > According to Documentation/filesystems/proc.txt, kernel should swap one page > as vm.page-cluster is 0, while it seems not like so in mm/swapfile.c: > ... > int our_page_cluster = page_cluster; > ... > if (!our_page_cluster) /* no readahead */ > return 0; > ... > > It is better to remove that checkpoint. No, page_cluster 0 allows swapin one page at a time, but disallows swapin readahead (better named readaround) i.e. disallows reading more than the one page actually requested. Compare with how valid_swaphandles() is used from swapin_readahead(): there's actually one extra call to read_swap_cache_async() - because we must ignore failure on the readaround but not on the page requested. That "return 0" avoids the overhead of a pointlessly doubled read_swap_cache_async() when there's only one page to be read. Your patch might be needed if you'd found that swapin of one page was not working at all - but you'd be making a stronger case if you'd found that, I think! Hugh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists