linux-kernel - Re: [PATCH 1/7] Adding empia base driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081102022728.68e5e564@pedra.chehab.org>
Date:	Sun, 2 Nov 2008 02:27:28 -0200
From:	Mauro Carvalho Chehab <mchehab@...radead.org>
To:	Hans Verkuil <hverkuil@...all.nl>
Cc:	"Markus Rechberger" <mrechberger@...il.com>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	em28xx <em28xx@...ntral.de>, acano@...tmail.fm,
	"Andre Kelmanson" <akelmanson@...il.com>,
	"Bouwsma Barry" <freebeer.bouwsma@...il.com>,
	"Dan Kreiser" <kreiser@...ormatik.hu-berlin.de>,
	"Frank Neuber" <fn@...nelport.de>,
	"Jelle de Jong" <jelledejong@...ercraft.nl>,
	"John Stowers" <john.stowers.lists@...il.com>,
	"Lukas Kuna" <lukas.kuna@...anet.net>,
	"Stefan Vonolfen" <stefan.vonolfen@...il.com>,
	"Stephan Berberig" <s.berberig@...or.de>,
	"Thomas Giesecke" <thomas.giesecke@...mbh-naumburg.de>,
	"Vitaly Wool" <vwool@...mvista.com>,
	"Zhenyu Wang" <zhen78@...il.com>,
	v4l <video4linux-list@...hat.com>, linux-dvb@...uxtv.org,
	greg@...ah.com, Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH 1/7] Adding empia base driver

On Sat, 1 Nov 2008 14:59:17 +0100
Hans Verkuil <hverkuil@...all.nl> wrote:

> Hi Markus,
> 
> As promised I've done a review of your empia driver and looked at what 
> needs to be done to get it into the kernel.
> 
> First of all, I've no doubt that your empia driver is better and 
> supports more devices than the current em28xx driver. I also have no 
> problem adding your driver separate from the current driver. It's been 
> done before (certain networking drivers spring to mind) and while 
> obviously not ideal I expect that the older em28xx driver can probably 
> be removed after a year or something like that.
> 
> In my opinion it's pretty much hopeless trying to convert the current 
> em28xx driver into what you have. It's a huge amount of work that no 
> one wants to do and (in this case) with very little benefit. Of course, 
> Mauro has the final say in this.
> 

Both upstream and the 4 duplicated drivers have similar functionality. Also,
the upstream driver is actively maintained. So, there's no sense on accepting
those duplicated drivers.

Also, just replacing one existing driver by a newer one will cause regressions
on some already fixed bugs and remove some improvements that the upstream driver
suffered.

If there's a bug or a lack of functionality on em28xx, cx25843, xc5000 or
tuner-xc2028, it is just a matter of submitting patches fixing those bugs or
adding newer features.

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/