lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 01 Nov 2008 21:40:08 -0700 (PDT) From: David Miller <davem@...emloft.net> To: fubar@...ibm.com Cc: shemminger@...tta.com, dada1@...mosbay.com, zbr@...emap.net, ilpo.jarvinen@...sinki.fi, rjw@...k.pl, mingo@...e.hu, s0mbre@...rvice.net.ru, a.p.zijlstra@...llo.nl, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, efault@....de, akpm@...ux-foundation.org Subject: Re: [tbench regression fixes]: digging out smelly deadmen. From: Jay Vosburgh <fubar@...ibm.com> Date: Fri, 31 Oct 2008 17:16:33 -0700 > I suspect it could also be tucked away in skb_bond_should_drop, > which is called both by the standard input path and the VLAN accelerated > path to see if the packet should be tossed (e.g., it arrived on an > inactive bonding slave). > > Since last_rx is part of struct net_device, I don't think any > additional bonding internals knowledge would be needed. It could be > arranged to only update last_rx for devices that are actually bonding > slaves. > > Just off the top of my head (haven't tested this), something > like this: ... > > That doesn't move the storage out of struct net_device, but it > does stop the updates for devices that aren't bonding slaves. It could > probably be refined further to only update when the ARP monitor is > running (the gizmo that uses last_rx). I like this very much. Jay can you give this a quick test by just trying this patch and removing the ->last_rx setting in the driver you use for your test? Once you do that, I'll apply this to net-next-2.6 and do the leg work to zap all of the ->last_rx updates from the entire tree. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists