lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 2 Nov 2008 13:13:20 +0100 From: Dominik Brodowski <linux@...inikbrodowski.net> To: Kay Sievers <kay.sievers@...y.org> Cc: linux-kernel <linux-kernel@...r.kernel.org>, Greg KH <greg@...ah.com> Subject: Re: pcmcia: struct device - replace bus_id with dev_name(), dev_set_name() Hi, On Sat, Nov 01, 2008 at 11:46:06AM +0100, Kay Sievers wrote: > From: Kay Sievers <kay.sievers@...y.org> > Subject: pcmcia: struct device - replace bus_id with dev_name(), dev_set_name() > > Cc: Dominik Brodowski <linux@...inikbrodowski.net> > Acked-by: Greg Kroah-Hartman <gregkh@...e.de> > Signed-Off-By: Kay Sievers <kay.sievers@...y.org> is this to go in via -pcmcia or via -driver-core? > diff --git a/drivers/pcmcia/cs.c b/drivers/pcmcia/cs.c > index c68c5d3..5d0e60e 100644 > --- a/drivers/pcmcia/cs.c > +++ b/drivers/pcmcia/cs.c > @@ -226,7 +226,7 @@ int pcmcia_register_socket(struct pcmcia_socket *socket) > /* set proper values in socket->dev */ > dev_set_drvdata(&socket->dev, socket); > socket->dev.class = &pcmcia_socket_class; > - snprintf(socket->dev.bus_id, BUS_ID_SIZE, "pcmcia_socket%u", socket->sock); > + dev_set_name(&socket->dev, "pcmcia_socket%u", socket->sock); In other places, you check for !dev_name() afterwards -- why not here? Otherwise it is Acked-by: Dominik Brodowski <linux@...inikbrodowski.net> Thanks! Dominik -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists