lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 3 Nov 2008 17:14:50 +0300 From: Evgeniy Polyakov <zbr@...emap.net> To: Phillip Lougher <phillip@...gher.demon.co.uk> Cc: akpm@...ux-foundation.org, linux-embedded@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, tim.bird@...sony.com Subject: Re: [PATCH V2 00/16] Squashfs: compressed read-only filesystem Hi. On Wed, Oct 29, 2008 at 01:49:55AM +0000, Phillip Lougher (phillip@...gher.demon.co.uk) wrote: > Summary of changes in patch respin: > > 1. Functions changed to return 0 on success and -ESOMETHING on error > 2. Header files moved from include/linux to fs/squashfs > 3. Variables changed to use sb and inode > 4. Number of squashfs_read_metadata() parameters reduced > 5. Xattr placeholder code tweaked > 6. TRACE and ERROR macros fixed to use pr_debug and pr_warning > 7. Some obsolete macros in squashfs_fs.h removed > 8. A number of gotos to return statements replaced with direct returns > 9. Sparse with endian checking (make C=2 CHECKFLAGS="-D__CHECK_ENDIAN__") > errors fixed > 10. get_dir_index_using_name() misaligned access fixed > 11. Fix a couple of printk warnings on PPC64 > 12. Shorten a number of variable names Looks very good. As a generic comment of the style: imho u64 is more appropriate than long long, at least it is less keys to press when typing :) -- Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists