linux-kernel - Re: [ath5k-devel] [PATCH] ath5k: fix detection of jumbo frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081103094047.7zjz0fcy88gc4wo8-cebfxv@webmail.spamcop.net>
Date:	Mon, 03 Nov 2008 09:40:47 -0500
From:	Pavel Roskin <proski@....org>
To:	Bob Copeland <me@...copeland.com>
Cc:	jirislaby@...il.com, ath5k-devel@...ts.ath5k.org,
	linux-wireless@...r.kernel.org, linville@...driver.com,
	michael+ath5k@...pelberg.de, linux-kernel@...r.kernel.org
Subject: Re: [ath5k-devel] [PATCH] ath5k: fix detection of jumbo frames

Quoting Bob Copeland <me@...copeland.com>:

> On Mon, Nov 3, 2008 at 8:35 AM, Pavel Roskin <proski@....org> wrote:
>> Thanks for catching it!  Please mention rs_antenna in addition to
>> rs_more.
>>
>>> -     rs->rs_antenna = rx_status->rx_status_0 &
>>> -             AR5K_5210_RX_DESC_STATUS0_RECEIVE_ANTENNA;
>>> -     rs->rs_more = rx_status->rx_status_0 &
>>> -             AR5K_5210_RX_DESC_STATUS0_MORE;
>>> +     rs->rs_antenna = AR5K_REG_MS(rx_status->rx_status_0,
>>> +             AR5K_5210_RX_DESC_STATUS0_RECEIVE_ANTENNA);
>>> +     rs->rs_more = AR5K_REG_MS(rx_status->rx_status_0,
>>> +             AR5K_5210_RX_DESC_STATUS0_MORE);
>>
>> rs_more should be boolean.  It would be better to use "!!" to calculate
>> rs_rate.  No need to shift anything.  As for rs_antenna, it's fine with
>    ^^^^^^
> I assume you meant rs_more again:  rs_more = !!(rx_status_0 & ...)

Yes, sorry.

>>> +#define AR5K_5212_RX_DESC_STATUS0_DECOMP_CRC_ERROR_S 13
>>
>> This doesn't belong to the patch.  It looks like it's another boolean
>> value, but it's not currently used.
>
> ACK, all valid.  I'll respin.

Please do.

-- 
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/