linux-kernel - Re: bdi: register sysfs bdi device only once per queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 03 Nov 2008 17:08:50 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Kay Sievers <kay.sievers@...y.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Folkert van Heusden <folkert@...heusden.com>,
	Peter Korsgaard <jacmet@...site.dk>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	David Woodhouse <dwmw2@...radead.org>
Subject: Re: bdi: register sysfs bdi device only once per queue

On Mon, 2008-11-03 at 16:53 +0100, Kay Sievers wrote:
> Andrew, can you pick this up this please?
> 
> Thanks,
> Kay
> 
> 
> From: Kay Sievers <kay.sievers@...y.org>
> Subject: bdi: register sysfs bdi device only once per queue
> 
> Devices which share the same queue, like floppies and mtd devices,
> get registered multiple times in the bdi interface, but bdi accounts
> only the last registered device of the devices sharing one queue.

David, is there any reason the mtd devices do this?

> On remove, all earlier registered devices leak, stay around in
> sysfs, and cause "duplicate filename" errors if the devices are
> re-created.
> 
> This prevents the creation of multiple bdi interfaces per queue,
> and the bdi device will carry the dev_t name of the block device
> which is the first one registered, of the pool of devices using
> the same queue.
> 
> Tested-By: Peter Korsgaard <jacmet@...site.dk>
> Acked-By: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Signed-Off-By: Kay Sievers <kay.sievers@...y.org>
> ---
> 
> diff --git a/mm/backing-dev.c b/mm/backing-dev.c
> index f2e574d..e6676e5 100644
> --- a/mm/backing-dev.c
> +++ b/mm/backing-dev.c
> @@ -176,6 +176,9 @@ int bdi_register(struct backing_dev_info *bdi, struct device *parent,
>  	int ret = 0;
>  	struct device *dev;
>  
> +	if (bdi->dev)
> +		goto exit;
> +
>  	va_start(args, fmt);
>  	dev = device_create_vargs(bdi_class, parent, MKDEV(0, 0), bdi, fmt, args);
>  	va_end(args);

Would it make sense to make it print something like, please fix me?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/