lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 3 Nov 2008 21:14:46 +0300
From:	Dmitry <>
	"Andrew Morton" <>,
	"Mark Brown" <>
Subject: Re: [PATCH] power_supply: only register tosa_battery driver on tosa

2008/11/3 Anton Vorontsov <>:
> On Mon, Nov 03, 2008 at 08:09:14PM +0300, Dmitry wrote:
> [...]
>> >> Yup.
>> >> I see few ways to resolve this:
>> >> * write better wm97xx interface. Dunno if that is feasible or possible.
>> >>   One of the possible solutions is to pass battery and ts device names
>> >>   and data from within board data via ac97 layer to wm97xx-core. This
>> >>   will provide several benefits (e.g. then we can drop lots of parameters
>> >>   from wm97xx-core, which are really board parameters).
>> >
>> > That would be great indeed. But for now, just don't compile the two
>> > drivers on the tosa platform. No need for machine_is_*() hacks...
>> That is a bit strange requirement. During several past months there was
>> a lot of efforts put into supporting multi-machine PXA kernel images.
> Yes, I know this.
> But you're implementing hacks instead of fixing the problem.
> Btw, you inserted the machine_is() into the tosa driver, but
> wm97xx driver registers unconditionally. That could be a problem
> when wm97xx loads first, and then you try to load the tosa_battery
> module on tosa machine.
> Let's insert machine_is() hack into the wm97xx driver as well?

That's why I suggested moving driver registration into _set_pdata()
function in that driver.

> --
> Anton Vorontsov
> email:
> irc://

With best wishes
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists