linux-kernel - Re: [RFC PATCH 2/5] iscsi: bugfix for displaying IPv6 address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1225743622.3619.67.camel@johannes.berg>
Date:	Mon, 03 Nov 2008 21:20:22 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Harvey Harrison <harvey.harrison@...il.com>, davem@...emloft.net,
	joe@...ches.com, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 2/5] iscsi: bugfix for displaying IPv6 address

On Mon, 2008-11-03 at 12:16 -0800, Andrew Morton wrote:
> On Mon, 27 Oct 2008 21:05:17 -0700
> Harvey Harrison <harvey.harrison@...il.com> wrote:
> 
> > Notice that ip is a u8 *, so currently every other byte is
> > being truncated here.
> > 
> 
> I don't understand that bug description.  The code looks OK to me?

> > -		str += sprintf(str, NIP6_FMT, ntohs(ip[0]), ntohs(ip[1]),
> > -			       ntohs(ip[2]), ntohs(ip[3]), ntohs(ip[4]),
> > -			       ntohs(ip[5]), ntohs(ip[6]), ntohs(ip[7]));
> > +		str += sprintf(str, "%p6", ip);

If ip is a u8 * these ntohs are operating on bytes which is bogus, and
NIP6_FMT expects to get 8 u16s, not 8 u8s.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)