linux-kernel - Re: [PATCH] intel_menlo: max_state is unsigned, invalid test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081103143526.375be238.akpm@linux-foundation.org>
Date:	Mon, 3 Nov 2008 14:35:26 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	roel kluin <roel.kluin@...il.com>
Cc:	len.brown@...el.com, linux-kernel@...r.kernel.org,
	linux-acpi@...r.kernel.org
Subject: Re: [PATCH] intel_menlo: max_state is unsigned, invalid test

On Wed, 29 Oct 2008 17:06:47 -0400
roel kluin <roel.kluin@...il.com> wrote:

> max_state is unsigned, so the test is invalid.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> I think max_state can only become -1, no? then probably a different
> patch is required.
> I may not be able to respond for a few weeks.
> 
> diff --git a/drivers/misc/intel_menlow.c b/drivers/misc/intel_menlow.c
> index e00a275..980171d 100644
> --- a/drivers/misc/intel_menlow.c
> +++ b/drivers/misc/intel_menlow.c
> @@ -121,7 +121,7 @@ static int memory_set_cur_bandwidth(struct thermal_cooling_device *cdev,
>  	if (memory_get_int_max_bandwidth(cdev, &max_state))
>  		return -EFAULT;
>  
> -	if (max_state < 0 || state > max_state)
> +	if (max_state == -1 || state > max_state)
>  		return -EINVAL;
>  
>  	arg_list.count = 1;
> 

hm, maybe.

This can only happen if acpi_evaluate_integer(MEMORY_GET_BANDWIDTH)
returned no-error and a bandwidth of zero (I assume).

Is this a special case which the driver really wanted to handle?  If
so, why is "0" the only bad value which we're checking for?  Or is this
all some big brainfart which should be removed?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/