linux-kernel - Re: sound: struct device - replace bus_id with dev_name(), dev_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ac3eb2510811030035y3e72bc9dt732c4a3688bae3ec@mail.gmail.com>
Date:	Mon, 3 Nov 2008 09:35:32 +0100
From:	"Kay Sievers" <kay.sievers@...y.org>
To:	"Takashi Iwai" <tiwai@...e.de>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	"Greg KH" <greg@...ah.com>
Subject: Re: sound: struct device - replace bus_id with dev_name(), dev_set_name()

On Mon, Nov 3, 2008 at 09:06, Takashi Iwai <tiwai@...e.de> wrote:
> At Sun, 02 Nov 2008 12:19:16 +0100,
> I wrote:
>>
>> At Sun, 02 Nov 2008 03:50:35 +0100,
>> Kay Sievers wrote:
>> >
>> > --- a/sound/isa/ad1848/ad1848.c
>> > +++ b/sound/isa/ad1848/ad1848.c
>> > @@ -70,15 +70,15 @@ static int __devinit snd_ad1848_match(st
>> >             return 0;
>> >
>> >     if (port[n] == SNDRV_AUTO_PORT) {
>> > -           snd_printk(KERN_ERR "%s: please specify port\n", dev->bus_id);
>> > +           snd_printk(KERN_ERR "%s: please specify port\n", dev_name(dev));
>>
>> All the changes in sound/isa/* seem to be better fixed by replacement
>> with dev_err().
>>
>> Other changes look good to me.
>
> I dropped sound/isa/* changes from your patch and applied to sound git
> tree now.
>
> The sound/isa* parts are replacement with dev_err() and co as well, so
> there is no longer dev->bus_id in sound directory.

Very nice. Thanks for your prompt reply, it helps a lot,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/