linux-kernel - Re: [PATCH] sched: add sanity check in partition_sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081104092848.GM23790@elte.hu>
Date:	Tue, 4 Nov 2008 10:28:48 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH] sched: add sanity check in partition_sched_domains()

* Li Zefan <lizf@...fujitsu.com> wrote:

> It's wrong to make dattr_new = NULL if doms_new == NULL, it introduces
> memory leak if dattr_new != NULL. Fortunately dattr_new is always NULL
> in this case. So remove the code and add a sanity check.
> 
> Signed-off-by: Li Zefan <lizf@...fujitsu.com>
> ---
>  kernel/sched.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

applied to tip/sched/core, thanks!

a small detail, i changed this:

> +		BUG_ON(dattr_new);

to WARN_ON_ONCE().

If there's a rare setup-time memory leak we dont want to crash the box 
via a BUG_ON(), as that only results in unhappy users. We want a 
WARN_ON_ONCE() so that we get nice bugreports and kerneloops.org 
coverage as well instead.

We use BUG_ON() in new code only in the rarest of circumstances: if we 
absolutely want to bring down the box right there - because there's a 
serious risk of data corruption, security breach, etc.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/