lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 4 Nov 2008 16:15:40 -0200 From: Eduardo Habkost <ehabkost@...hat.com> To: Avi Kivity <avi@...hat.com>, Ingo Molnar <mingo@...e.hu> Cc: "Eric W. Biederman" <ebiederm@...ssion.com>, Simon Horman <horms@...ge.net.au>, Andrew Morton <akpm@...l.org>, Vivek Goyal <vgoyal@...hat.com>, Haren Myneni <hbabu@...ibm.com>, Andrey Borzenkov <arvidjaar@...l.ru>, mingo@...hat.com, "Rafael J. Wysocki" <rjw@...k.pl>, kexec@...ts.infradead.org, kvm@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 07/16] x86: Make nmi_shootdown_cpus() available on !SMP and !X86_LOCAL_APIC On Tue, Nov 04, 2008 at 12:52:35PM -0200, Eduardo Habkost wrote: > The X86_LOCAL_APIC #ifdef was for kdump. For !SMP, the function simply > does nothing. > The bit below is also needed. It can be added to the series right before patch 07/16. After getting some review, I will resubmit the series with it, and with a few style fixes suggested by checkpatch. --- From: Eduardo Habkost <ehabkost@...hat.com> Subject: [PATCH 06.1/16] x86: Disable IRQs before doing anything on nmi_shootdown_cpus() We need to know on which CPU we are running on, and we don't want to be preempted while doing this. Signed-off-by: Eduardo Habkost <ehabkost@...hat.com> --- arch/x86/kernel/reboot.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c index 23a9d78..407106e 100644 --- a/arch/x86/kernel/reboot.c +++ b/arch/x86/kernel/reboot.c @@ -577,6 +577,7 @@ static struct notifier_block crash_nmi_nb = { void nmi_shootdown_cpus(nmi_shootdown_cb callback) { unsigned long msecs; + local_irq_disable(); /* Make a note of crashing cpu. Will be used in NMI callback.*/ crashing_cpu = safe_smp_processor_id(); -- 1.5.5.GIT -- Eduardo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists