linux-kernel - Re: [PATCH] EHCI pci-quirks.c: wait for BIOS handoff too long

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <490FDE72.9060400@garzik.org>
Date:	Tue, 04 Nov 2008 00:32:34 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Steven Noonan <steven@...inklabs.net>
CC:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Alan Stern <stern@...land.harvard.edu>,
	Greg KH <greg@...ah.com>, David Brownell <david-b@...bell.net>
Subject: Re: [PATCH] EHCI pci-quirks.c: wait for BIOS handoff too long

Steven Noonan wrote:
> Instead of waiting a painful 5000ms, quirk_usb_disable_ehci() now does a
> 1000ms loop to wait for the BIOS to acknowledge the handoff.
> 
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Alan Stern <stern@...land.harvard.edu>
> Cc: Greg KH <greg@...ah.com>
> Cc: David Brownell <david-b@...bell.net>
> Signed-off-by: Steven Noonan <steven@...inklabs.net>
> ---
>  drivers/usb/host/pci-quirks.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
> index ae6e70e..1968ba1 100644
> --- a/drivers/usb/host/pci-quirks.c
> +++ b/drivers/usb/host/pci-quirks.c
> @@ -271,7 +271,7 @@ static void __devinit quirk_usb_disable_ehci(struct pci_dev *pdev)
>  			/* if boot firmware now owns EHCI, spin till
>  			 * it hands it over.
>  			 */
> -			msec = 5000;
> +			msec = 1000;
>  			while ((cap & EHCI_USBLEGSUP_BIOS) && (msec > 0)) {
>  				tried_handoff = 1;

That tells us nothing about the original reason for choosing the 5000 
value, and what if any impact lowering the value has on those who 
thought 5000 was needed.

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/