linux-kernel - Re: [patch] generic-ipi: fix the smp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081104222509.GA12358@linux-os.sc.intel.com>
Date:	Tue, 4 Nov 2008 14:25:10 -0800
From:	Suresh Siddha <suresh.b.siddha@...el.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Jeremy Fitzhardinge <jeremy@...p.org>,
	"Siddha, Suresh B" <suresh.b.siddha@...el.com>,
	"jens.axboe@...cle.com" <jens.axboe@...cle.com>,
	"paulmck@...ux.vnet.ibm.com" <paulmck@...ux.vnet.ibm.com>,
	"nickpiggin@...oo.com.au" <nickpiggin@...oo.com.au>,
	"torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Mallick, Asit K" <asit.k.mallick@...el.com>,
	venkatesh.pallipadi@...el.com
Subject: Re: [patch] generic-ipi: fix the smp_mb() placement

On Tue, Nov 04, 2008 at 02:19:56AM -0700, Ingo Molnar wrote:
> 
> * Jeremy Fitzhardinge <jeremy@...p.org> wrote:
> 
> > Ingo Molnar wrote:
> >> ok - so that makes it a v2.6.28 item i guess.
> >>   
> >
> > The case Suresh is talking about was a fix to Xen itself, rather 
> > than on the kernel side, so it doesn't need to be a .28 issue on 
> > Xen's account.
> 
> ok - but still the portion of the fix that strengthens barriers looks 
> obvious to have and there's little downside that i can see.
> 
> Suresh, you might want to split the patch(es) in two: get the barrier 
> strengthening changes into v2.6.28 (to fix the x2apic bug), while the 
> aspects that _weaken_ barriers can wait for v2.6.29.
> 
> With that it would be a 100% safe change for v2.6.28-rc4.

Ok. I just posted three patches (including the x86 specific change).

[patch 1/3] generic-ipi: add smp_mb() before sending the IPI
[patch 2/3] x86: Add smp_mb() before sending INVALIDATE_TLB_VECTOR
[patch 3/3] generic-ipi: fix the smp_mb() usage

First two patches are safe to go into v2.6.28. Third patch can wait for v2.6.29.

thanks,
suresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/