linux-kernel - Re: [PATCH] x86: make NR_IRQS on 32bit is same to 64bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 04 Nov 2008 14:34:30 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: make NR_IRQS on 32bit is same to 64bit

Ben Hutchings wrote:
> On Tue, 2008-11-04 at 14:10 -0800, Yinghai Lu wrote:
>> Impact: so NR_IRQS is bigger enough for system with lots of apic/pins
>>
>> Now: if IO_APIC is there, will have big NR_IRQS
>>
>> otherwise still use 224
> [...]
> 
> I have no idea whether this is useful, but it doesn't solve the general
> problem that probe_nr_irqs() can return a value > NR_IRQS.  So far as I
> can see it can return up to 2 * 24 * MAX_IO_APICS which may be greater
> than NR_VECTORS + (32 * max(MAX_IO_APICS, NR_CPUS)).

your patch is still needed...
also please add one WARN_ON when nr > NR_IRQS.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/