linux-kernel - Re: [PATCH] sata_via: restore vt*_prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 04 Nov 2008 01:10:32 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Marcin Slusarz <marcin.slusarz@...il.com>
CC:	LKML <linux-kernel@...r.kernel.org>, Tejun Heo <tj@...nel.org>,
	Joseph Chan <JosephChan@....com.tw>,
	Jeff Garzik <jgarzik@...hat.com>, linux-ide@...r.kernel.org
Subject: Re: [PATCH] sata_via: restore vt*_prepare_host error handling

Marcin Slusarz wrote:
> commit b9d5b89b487517cbd4cb4702da829e07ef9e4432 (sata_via: fix support
> for 5287) accidently (?) removed vt*_prepare_host error handling - restore it
> 
> catched by gcc:
> drivers/ata/sata_via.c: In function 'svia_init_one':
> drivers/ata/sata_via.c:567: warning: 'host' may be used uninitialized in this function
> 
> Signed-off-by: Marcin Slusarz <marcin.slusarz@...il.com>
> Cc: Tejun Heo <tj@...nel.org>
> Cc: Joseph Chan <JosephChan@....com.tw>
> Cc: Jeff Garzik <jgarzik@...hat.com>
> ---
>  drivers/ata/sata_via.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/ata/sata_via.c b/drivers/ata/sata_via.c
> index 62367fe..c18935f 100644
> --- a/drivers/ata/sata_via.c
> +++ b/drivers/ata/sata_via.c
> @@ -602,8 +602,10 @@ static int svia_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>  		rc = vt8251_prepare_host(pdev, &host);
>  		break;
>  	default:
> -		return -EINVAL;
> +		rc = -EINVAL;
>  	}
> +	if (rc)
> +		return rc;

applied


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/