linux-kernel - Re: [STAGING] slicoss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 05 Nov 2008 11:52:17 +0200
From:	Lior Dotan <liodot@...il.com>
To:	Jiri Slaby <jirislaby@...il.com>, gregkh@...e.de
CC:	linux-kernel@...r.kernel.org, charrer@...critech.com
Subject: Re: [STAGING] slicoss - use kzalloc

> On 11/05/2008 10:27 AM, Lior Dotan wrote:
>> This patch uses kzalloc() where really applicable.
> 
> ack this, but there is another problem.
> 
> sizeof(struct physcard *) is wrong size for that allocation, care to send a fix
> for this (and revice the rest of allocations)? I wonder how this could work with
Fix attached. I only found two other places with the same problem.

> SLAB_DEBUG on, maybe nobody tried...
AFAIK there aren't a lot of testers for this drivers so the few that 
does probably didn't try it.



Fix sizeof to use the right type

Signed-off-by: Lior Dotan <liodot@...il.com>

View attachment "slicoss-fix-sizeof.patch" of type "text/plain" (1190 bytes)