linux-kernel - Re: [PATCH] selinux: recognize netlink messages for 'ip addrlabel'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1225893945.19111.70.camel@moss-spartans.epoch.ncsc.mil>
Date:	Wed, 05 Nov 2008 09:05:45 -0500
From:	Stephen Smalley <sds@...ho.nsa.gov>
To:	Michal Schmidt <mschmidt@...hat.com>
Cc:	James Morris <jmorris@...ei.org>, linux-kernel@...r.kernel.org,
	Eric Paris <eparis@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] selinux: recognize netlink messages for 'ip addrlabel'

On Wed, 2008-11-05 at 13:35 +0100, Michal Schmidt wrote:
> In enforcing mode '/sbin/ip addrlabel' results in a SELinux error:
> type=SELINUX_ERR msg=audit(1225698822.073:42): SELinux:  unrecognized
> netlink message type=74 for sclass=43
> 
> The problem is missing RTM_*ADDRLABEL entries in SELinux's netlink
> message types table.
> 
> Reported in https://bugzilla.redhat.com/show_bug.cgi?id=469423
> 
> Signed-off-by: Michal Schmidt <mschmidt@...hat.com>

Acked-by:  Stephen Smalley <sds@...ho.nsa.gov>

> ---
>  security/selinux/nlmsgtab.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/security/selinux/nlmsgtab.c b/security/selinux/nlmsgtab.c
> index ff59c0c..4ed7bab 100644
> --- a/security/selinux/nlmsgtab.c
> +++ b/security/selinux/nlmsgtab.c
> @@ -63,6 +63,9 @@ static struct nlmsg_perm nlmsg_route_perms[] =
>  	{ RTM_GETANYCAST,	NETLINK_ROUTE_SOCKET__NLMSG_READ  },
>  	{ RTM_GETNEIGHTBL,	NETLINK_ROUTE_SOCKET__NLMSG_READ  },
>  	{ RTM_SETNEIGHTBL,	NETLINK_ROUTE_SOCKET__NLMSG_WRITE },
> +	{ RTM_NEWADDRLABEL,	NETLINK_ROUTE_SOCKET__NLMSG_WRITE },
> +	{ RTM_DELADDRLABEL,	NETLINK_ROUTE_SOCKET__NLMSG_WRITE },
> +	{ RTM_GETADDRLABEL,	NETLINK_ROUTE_SOCKET__NLMSG_READ  },
>  };
>  
>  static struct nlmsg_perm nlmsg_firewall_perms[] =
-- 
Stephen Smalley
National Security Agency

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/